Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update the installation guides to use the next tag #41558

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

mnajdova
Copy link
Member

I noticed that we were missing the <!-- #default-branch-switch --> statement on the installation guides. I've udpated the readmes and the docs and added the comment.

@mnajdova mnajdova added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes labels Mar 19, 2024
@danilo-leal
Copy link
Contributor

Should we add this callout to each installation page? The X components have it:

Screenshot 2024-03-19 at 09 23 59

@mnajdova mnajdova marked this pull request as ready for review March 19, 2024 12:34
@mnajdova
Copy link
Member Author

Should we add this callout to each installation page? The X components have it:

Sure we can add it 👍 Let me update the PR.

@DiegoAndai
Copy link
Member

Do you think we should do this right away? I think we should add a callout to opt-in to the next version instead of updating the command right away, at least until the beta release.

@danilo-leal
Copy link
Contributor

I guess it's fine because the callout would only be visible if you're viewing the docs with the v6 version selected, right? If you're within the v5 version of the docs, I'd agree, yeah, that you shouldn't see the installation commands defaulting to v6.

@mnajdova
Copy link
Member Author

Yes, the callout and the instructions are shown in next.mui.com if someone comes to this subdomain they should see next as a tag, and the callout makes sense just as a precaution

@DiegoAndai
Copy link
Member

Oh! My bad, that makes sense

@mnajdova mnajdova merged commit d37dd5c into mui:next Mar 19, 2024
22 checks passed
@Janpot Janpot mentioned this pull request Mar 25, 2024
1 task
pluvio72 pushed a commit to pluvio72/material-ui that referenced this pull request Mar 29, 2024
siriwatknp added a commit to siriwatknp/material-ui that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants