Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Fix landing page template's h1 size #41543

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Mar 18, 2024

Added clamp() to the h1 element in the landing page template to fix the massive layout shift on mobile when switching themes.

https://deploy-preview-41543--material-ui.netlify.app/material-ui/getting-started/templates/landing-page/

@zanivan zanivan added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer labels Mar 18, 2024
@zanivan zanivan self-assigned this Mar 18, 2024
@mui-bot
Copy link

mui-bot commented Mar 18, 2024

Netlify deploy preview

https://deploy-preview-41543--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e714f82

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Glad we fixed this — left a couple of small remarks. (Also, you can cut the component="h1" prop given the variant is the same as the tag we want this component to render as)

@zanivan zanivan merged commit e164e6b into mui:master Mar 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants