Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Make the Algolia search input label invisible #41542

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Mar 18, 2024

I don't think this label existed in the Algolia search input before or I just recently noticed it was visible, even though its class name is DocSearch-VisuallyHiddenForAccessibility. I guess we indeed don't want that to be visible as it overlaps with the input's placeholder, but it should still be there for accessibility. So, in this PR, I'm just using the available class to add CSS that will visually hide it, as the class name suggests it should be :)

Before After
Screenshot 2024-03-18 at 09 30 12 Screenshot 2024-03-18 at 09 30 20

@danilo-leal danilo-leal added accessibility a11y design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Mar 18, 2024
@danilo-leal danilo-leal requested a review from a team March 18, 2024 12:29
@danilo-leal danilo-leal self-assigned this Mar 18, 2024
@mui-bot
Copy link

mui-bot commented Mar 18, 2024

Netlify deploy preview

https://deploy-preview-41542--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3d7ba22

@danilo-leal danilo-leal merged commit c25a407 into mui:master Mar 18, 2024
19 checks passed
@danilo-leal danilo-leal deleted the fix-algolia-search-input-label branch March 18, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants