Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Breadcrumbs] Convert to support CSS extraction #41496

Merged
merged 3 commits into from
Mar 19, 2024
Merged

[material-ui][Breadcrumbs] Convert to support CSS extraction #41496

merged 3 commits into from
Mar 19, 2024

Conversation

aacevski
Copy link
Contributor

@aacevski aacevski commented Mar 14, 2024 •
edited
Loading

These steps were not needed for this component AFAIK, correct me if I'm wrong.

  • Move ownerState from the root style argument callback to variants
  • Use Object.entries(theme.palette) to populate colors
Screen.Recording.2024-03-14.at.19.58.44.mov

@siriwatknp

@mui-bot
Copy link

mui-bot commented Mar 14, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41496--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 373fda6

@brijeshb42
Copy link
Contributor

Can you also add the files added in the apps/* folders where you were testing the breadcrumb modifications ?

@aacevski
Copy link
Contributor Author

Can you also add the files added in the apps/* folders where you were testing the breadcrumb modifications ?

I have added them 🙌🏼

@danilo-leal danilo-leal added component: breadcrumbs This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material package: pigment-css Specific to @pigment-css/* labels Mar 14, 2024
@aacevski
Copy link
Contributor Author

The e2e tests failed due to the the search being incorrect, however I haven't changed much there. Is my code related to it?

@brijeshb42
Copy link
Contributor

No. It's failing for all PRS and is unrelated to your changes.

siriwatknp
siriwatknp approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great thanks!

@siriwatknp siriwatknp added the on hold There is a blocker, we need to wait label Mar 15, 2024
@mnajdova mnajdova added the v6.x label Mar 15, 2024
@siriwatknp siriwatknp mentioned this pull request Mar 19, 2024
Closed
62 tasks
@mnajdova mnajdova changed the base branch from master to next March 19, 2024 09:31
@siriwatknp siriwatknp merged commit 0a9fe85 into mui:next Mar 19, 2024
19 of 20 checks passed
pluvio72 pushed a commit to pluvio72/material-ui that referenced this pull request Mar 29, 2024
@aacevski @pluvio72
[material-ui][Breadcrumbs] Convert to support CSS extraction (mui#41496)
91e32dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: breadcrumbs This is the name of the generic UI component, not the React module! on hold There is a blocker, we need to wait package: material-ui Specific to @mui/material package: pigment-css Specific to @pigment-css/* v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aacevski @mui-bot @brijeshb42 @siriwatknp @mnajdova @danilo-leal