Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Modal] Support CSS extraction #41483

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[material-ui][Modal] Support CSS extraction #41483

merged 1 commit into from
Mar 19, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Mar 13, 2024 •
edited
Loading

@sai6855 sai6855 added component: modal This is the name of the generic UI component, not the React module! package: pigment-css Specific to @pigment-css/* labels Mar 13, 2024
@sai6855 sai6855 marked this pull request as draft March 13, 2024 15:17
@mui-bot
Copy link

mui-bot commented Mar 13, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41483--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 1f1f69f

@sai6855 sai6855 marked this pull request as ready for review March 13, 2024 15:32
@sai6855 sai6855 requested a review from siriwatknp March 13, 2024 15:32
siriwatknp
siriwatknp approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sai6855
Copy link
Contributor Author

sai6855 commented Mar 14, 2024

@siriwatknp, can this PR be merged now or do you want to wait until next branch creation? If it's good to go, you can merge it since I can't.

@siriwatknp
Copy link
Member

@siriwatknp, can this PR be merged now or do you want to wait until next branch creation? If it's good to go, you can merge it since I can't.

All of these migration will be merged next week to next branch.

@siriwatknp siriwatknp added the on hold There is a blocker, we need to wait label Mar 15, 2024
@mnajdova mnajdova added the v6.x label Mar 15, 2024
@siriwatknp siriwatknp mentioned this pull request Mar 19, 2024
Closed
62 tasks
@mnajdova mnajdova changed the base branch from master to next March 19, 2024 09:32
@siriwatknp siriwatknp merged commit 4365357 into mui:next Mar 19, 2024
22 of 23 checks passed
@sai6855 sai6855 mentioned this pull request Mar 19, 2024
Merged
1 task
@sai6855 sai6855 removed the on hold There is a blocker, we need to wait label Mar 25, 2024
pluvio72 pushed a commit to pluvio72/material-ui that referenced this pull request Mar 29, 2024
@sai6855 @pluvio72
[material-ui][Modal] Support CSS extraction (mui#41483)
1cb4d70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: modal This is the name of the generic UI component, not the React module! package: pigment-css Specific to @pigment-css/* v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sai6855 @mui-bot @siriwatknp @mnajdova