[pigment-css][demo] Remove app specific pnpm workspace #41393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
brijeshb42
force-pushed
the
pigment/revert-nested-workspace
branch
2 times, most recently
from
26d9da2
to
97c2017
Compare
Netlify deploy previewhttps://deploy-preview-41393--material-ui.netlify.app/ Bundle size report |
siriwatknp
reviewed
Mar 7, 2024
brijeshb42
force-pushed
the
pigment/revert-nested-workspace
branch
6 times, most recently
from
74b8607
to
6a2f9d9
Compare
oliviertassinari
changed the title
github-actions
bot
added
the
PR: out-of-date
|
Can you update this PR with the new directories? |
brijeshb42
force-pushed
the
pigment/revert-nested-workspace
branch
from
6a2f9d9
to
ca9532e
Compare
github-actions
bot
removed
the
PR: out-of-date
brijeshb42
force-pushed
the
pigment/revert-nested-workspace
branch
8 times, most recently
from
eeee8b9
to
c694974
Compare
github-actions
bot
added
the
PR: out-of-date
brijeshb42
force-pushed
the
pigment/revert-nested-workspace
branch
from
c694974
to
1dc9931
Compare
github-actions
bot
removed
the
PR: out-of-date
|
@siriwatknp Can you look at this again? It's now rebased with |
brijeshb42
force-pushed
the
pigment/revert-nested-workspace
branch
3 times, most recently
from
ab54227
to
f214bdd
Compare
github-actions
bot
added
the
PR: out-of-date
and revert to using project workspace. Also fix a minor typing issue in the Vite app.
brijeshb42
force-pushed
the
pigment/revert-nested-workspace
branch
from
f214bdd
to
c6727de
Compare
github-actions
bot
removed
the
PR: out-of-date
siriwatknp
approved these changes
Mar 20, 2024
siriwatknp
reviewed
Mar 20, 2024
| @@ -55,10 +55,13 @@ export function withPigment(nextConfig: NextConfig, pigmentConfig?: PigmentOptio | |||
| placeholderCssFile: extractionFile, | |||
| }, | |||
| async asyncResolve(what: string, importer: string, stack: string[]) { | |||
| if (what.startsWith('__barrel_optimize__')) { | |||
There was a problem hiding this comment.
Should this be combined with the next/font below?
There was a problem hiding this comment.
I did it knowingly since I don't know yet what kind of exports __barrel_optimize__ expects. So I am just returning next-font for now.
In future, depending on any bug reports, it might require it's own dummy module similar to next-font.js.
There was a problem hiding this comment.
Got it, then I think it deserves a comment here.
pluvio72
pushed a commit
to pluvio72/material-ui
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and revert to using project workspace.
Fix a minor typing issue in the Vite app.
Fixes - #41342