Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix v4 docs <b> appearing in notifications #41390

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

peterwangsc
Copy link
Contributor

@peterwangsc peterwangsc commented Mar 7, 2024

Looks like the dangerouslySetInnerHTML usage isn't necessary anymore now that the <b> tags wrap the entire title on all of the visible notifications. I'm assuming that removing the <b> from each title and instead wrapping the title in <b> tags in the JSX here will get rid of the <b> tags showing up in the v4 docs, as it looks like they are using the same notifications.json file to render the text for their notifications. If my assumption is incorrect, feel free to ignore my PR.

v5 docs
image

v4 docs
image

@peterwangsc peterwangsc marked this pull request as draft March 7, 2024 06:57
@mui-bot
Copy link

mui-bot commented Mar 7, 2024

Netlify deploy preview

https://deploy-preview-41390--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 633e3e9

@peterwangsc peterwangsc marked this pull request as ready for review March 7, 2024 07:00
@peterwangsc
Copy link
Contributor Author

Running typescript checks passed on my machine. Not sure why it's failing in ci.

image

@peterwangsc
Copy link
Contributor Author

Also, I can't access the labels on this PR, someone please add the docs label to this change.

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation v4.x labels Mar 7, 2024
@ZeeshanTamboli ZeeshanTamboli requested a review from a team March 7, 2024 08:55
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to stop using this kind of API when we can 🤩

@alexfauquette
Copy link
Member

alexfauquette commented Mar 7, 2024

Also, I can't access the labels on this PR, someone please add the docs label to this change.

This should be fixed now (see #41392). I rerun the CI

Seems that we did not used links in those title since 2 years 👍

@alexfauquette alexfauquette merged commit a8ae789 into mui:master Mar 7, 2024
20 of 21 checks passed
@danilo-leal danilo-leal changed the title [docs] Fix v4 docs <b> appearing in notifications [docs-infra] Fix v4 docs <b> appearing in notifications Mar 7, 2024
@danilo-leal danilo-leal added scope: docs-infra Specific to the docs-infra product and removed docs Improvements or additions to the documentation labels Mar 7, 2024
cipherlogs pushed a commit to cipherlogs/material-ui that referenced this pull request Mar 8, 2024
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product v4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants