Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigment-css] Rename scope to @pigment-css #41354

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Mar 4, 2024

Updated the package name as per internal discussion and package name convention. See the discussion in https://www.notion.so/mui-org/pigment-css-npm-package-name-convention-5b0b75983d934c70aab12ae671198d8c

A continuation of #41317.

@brijeshb42 brijeshb42 requested review from siriwatknp, danilo-leal and a team March 4, 2024 13:56
@brijeshb42 brijeshb42 added the package: pigment-css Specific to @pigment-css/* label Mar 4, 2024
@mui-bot
Copy link

mui-bot commented Mar 4, 2024

Netlify deploy preview

https://deploy-preview-41354--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2d60388

@brijeshb42 brijeshb42 merged commit 6afcb73 into mui:master Mar 4, 2024
19 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 10, 2024

I'm making the page public so people can blame the history as well as linking it: https://www.notion.so/mui-org/pigment-css-npm-package-name-convention-5b0b75983d934c70aab12ae671198d8c (impossible to have external contributions too).

Also, I wasn't expecting https://twitter.com/olivtassinari/status/1765689661580595471 to validate this direction but it did 🤷‍♂️

SCR-20240310-cywo

@oliviertassinari oliviertassinari changed the title [pigment] Rename scope to @pigment-css [pigment-css] Rename scope to @pigment-css Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: pigment-css Specific to @pigment-css/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants