Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Tooltip] Support event handlers with extra parameters #41320

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 29, 2024

Resolves the problem with not propagating additional parameters here: mui/mui-x#12248 (comment).

If you do not agree with the proposal—we'll need to go for a different approach on X side.

@LukasTy LukasTy added component: tooltip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material package: joy-ui Specific to @mui/joy enhancement This is not a bug, nor a new feature labels Feb 29, 2024
@LukasTy LukasTy self-assigned this Feb 29, 2024
@mui-bot
Copy link

mui-bot commented Feb 29, 2024

Netlify deploy preview

https://deploy-preview-41320--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 14c47d1

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with the proposal. Let's wait @michaldudak.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siriwatknp siriwatknp merged commit 9e97e73 into mui:master Mar 13, 2024
23 checks passed
@siriwatknp siriwatknp mentioned this pull request Mar 13, 2024
@LukasTy LukasTy deleted the support-extra-tooltip-handler-params branch March 13, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature package: joy-ui Specific to @mui/joy package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants