Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Polish Button outline primary medium #41298

Merged
merged 1 commit into from
Feb 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions docs/src/modules/brandingTheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ export function getThemedComponents(): ThemeOptions {
}),
...(ownerState.size === 'medium' && {
fontSize: defaultTheme.typography.pxToRem(15),
padding: theme.spacing('8px', '10px', '8px', '12px'),
padding: theme.spacing('8px', '12px', '8px', '14px'),
fontWeight: theme.typography.fontWeightSemiBold,
borderRadius: 8,
'& > span': { transition: '0.2s', marginLeft: 4 },
Expand Down Expand Up @@ -508,7 +508,7 @@ export function getThemedComponents(): ThemeOptions {
0.8,
)} 0 -2px 0 inset, ${alpha(theme.palette.grey[200], 0.5)} 0 1px 2px 0`,
'&:hover': {
background: (theme.vars || theme).palette.primaryDark[50],
backgroundColor: (theme.vars || theme).palette.primaryDark[50],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, backgroundColor is the correct one then for the transitions 👍

},
...theme.applyDarkStyles({
color: (theme.vars || theme).palette.primaryDark[100],
Expand All @@ -533,7 +533,7 @@ export function getThemedComponents(): ThemeOptions {
0.2,
)} 0 -3px 0 inset, ${alpha(theme.palette.primary[100], 0.3)} 0 1px 2px 0`,
'&:hover': {
background: (theme.vars || theme).palette.primary[50],
backgroundColor: (theme.vars || theme).palette.primary[50],
borderColor: (theme.vars || theme).palette.primary[300],
},
...theme.applyDarkStyles({
Expand All @@ -552,7 +552,7 @@ export function getThemedComponents(): ThemeOptions {
}),
...(ownerState.variant === 'contained' &&
ownerState.color === 'primary' && {
color: '#FFF',
color: '#fff',
textShadow: `0 1px 1px ${alpha(theme.palette.common.black, 0.6)}`,
backgroundColor: (theme.vars || theme).palette.primary[500],
backgroundImage: `linear-gradient(180deg, ${alpha(
Expand All @@ -564,8 +564,10 @@ export function getThemedComponents(): ThemeOptions {
0.7,
)} 0 -3px 1px inset, ${alpha(theme.palette.common.black, 0.1)} 0 2px 4px 0`,
'&:hover': {
backgroundColor: (theme.vars || theme).palette.primary[500],
backgroundImage: 'none',
backgroundColor: (theme.vars || theme).palette.primary[700],
},
'&:active': {
backgroundColor: (theme.vars || theme).palette.primaryDark[700],
},
}),
}),
Expand Down
Loading