Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Adjust headings dark mode color #41292

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

danilo-leal
Copy link
Contributor

I have just realized that as we go down in the heading hierarchy, the colors gradually fade (getting greyer). I'm unsure whether this is good — headings should always be more prominent than paragraphs, regardless of their level. So, this PR makes all headings in dark mode the same color. This will also be consistent with how light mode already works!

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Feb 27, 2024
@danilo-leal danilo-leal self-assigned this Feb 27, 2024
@mui-bot
Copy link

mui-bot commented Feb 27, 2024

Netlify deploy preview

https://deploy-preview-41292--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against be0856a

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🚀

@danilo-leal danilo-leal merged commit 4d349d8 into mui:master Feb 27, 2024
21 checks passed
@danilo-leal danilo-leal deleted the adjust-dark-mode-heading-colors branch February 27, 2024 14:34
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants