-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system][docs] Tweak the Usage demos #41242
Merged
danilo-leal
merged 10 commits into
mui:master
from
danilo-leal:update-system-usage-demos
Mar 4, 2024
Merged
[system][docs] Tweak the Usage demos #41242
danilo-leal
merged 10 commits into
mui:master
from
danilo-leal:update-system-usage-demos
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Improvements or additions to the documentation
package: system
Specific to @mui/system
design
This is about UI or UX design, please involve a designer
labels
Feb 22, 2024
danilo-leal
requested review from
brijeshb42,
siriwatknp,
zanivan and
samuelsycamore
February 22, 2024 15:23
Netlify deploy previewBundle size report |
(Note: I have no idea why the test_regressions-1 is failing — would appreciate it if someone could shed some light! 😬) |
✅ Deploy Preview for resonant-twilight-4b0c91 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I'd appreciate an insight about why these tests are failing 😕 |
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Feb 28, 2024
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 1, 2024
@brijeshb42 & @siriwatknp any guidance about this one? 👀 |
brijeshb42
reviewed
Mar 4, 2024
brijeshb42
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
This is about UI or UX design, please involve a designer
docs
Improvements or additions to the documentation
package: system
Specific to @mui/system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some slight design tweaks to the MUI System usage demos. The main thing that caught my attention was that those demos weren't pulling the Box directly from the
@mui/system
package, which is confusing to me (not sure if that was intentional, though). This PR changes that, too. Aside from this, also added minor tweaks to the markdown.