[material-ui][Chip] Deprecate composed classes #41235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
docs
sai6855
changed the title
Netlify deploy previewBundle size report |
sai6855
commented
Feb 23, 2024
| ``` | ||
|
|
||
| ### Composed CSS classes | ||
|
|
There was a problem hiding this comment.
hey @DiegoAndai can you suggest description here similar to button classes description. Since multiple combinations of classes are deprecated, i'm not able to come up with description which address all types of combinations similar to Button, Alert
There was a problem hiding this comment.
I would do a list:
The CSS classes that composed the following props were deprecated:
- `variant` | `clickable` | `deletable` and `color`
- `avatar` and `color` | `size`
- `icon` and `color` | `size`
- `deleteIcon` and `color` | `size`
Here's how to migrate:What do you think?
There was a problem hiding this comment.
yeah i guess this is the best we can do given multiple combinations. label and size was missing in this list, i added in latest commit.
github-actions
bot
added
the
PR: out-of-date
DiegoAndai
reviewed
Feb 23, 2024
| ``` | ||
|
|
||
| ### Composed CSS classes | ||
|
|
There was a problem hiding this comment.
I would do a list:
The CSS classes that composed the following props were deprecated:
- `variant` | `clickable` | `deletable` and `color`
- `avatar` and `color` | `size`
- `icon` and `color` | `size`
- `deleteIcon` and `color` | `size`
Here's how to migrate:What do you think?
github-actions
bot
removed
the
PR: out-of-date
30 tasks
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #40417
Migration guide Preview: docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
docs preview: https://deploy-preview-41235--material-ui.netlify.app/material-ui/api/chip/#classes