[material-ui][Chip] Correct deleteIconColorPrimary and deleteIconColorSecondary class descriptions
#41231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sai6855
commented
Feb 22, 2024
sai6855
commented
- I have followed (at least) the PR section of the contributing guide.
sai6855
added
docs
Netlify deploy previewhttps://deploy-preview-41231--material-ui.netlify.app/ Bundle size report |
sai6855
commented
Feb 22, 2024
| @@ -78,9 +78,9 @@ export interface ChipClasses { | |||
| deleteIconSmall: string; | |||
| /** Styles applied to the deleteIcon element if `size="medium"`. */ | |||
| deleteIconMedium: string; | |||
| /** Styles applied to the deleteIcon element if `color="primary"` and `variant="filled"`. */ | |||
| /** Styles applied to the deleteIcon element if `color="primary"`. */ | |||
There was a problem hiding this comment.
deleteIconColorPrimary is applied to the deleteIcon irrespective of the variant value, so I've removed variant='filled' from the description.
there is already a class called deleteIconFilledColorPrimary combining color and variant
ZeeshanTamboli
approved these changes
Feb 22, 2024
ZeeshanTamboli
changed the title
deleteIconColorPrimary and deleteIconColorSecondary class descriptiondeleteIconColorPrimary and deleteIconColorSecondary class descriptions
Noted. |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 8, 2024
…olorSecondary` class descriptions (mui#41231)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.