-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Improve the footer's chip contrast #41209
[website] Improve the footer's chip contrast #41209
Conversation
Netlify deploy previewhttps://deploy-preview-41209--material-ui.netlify.app/ Bundle size report |
I wonder if we should come up with a storybook for the branding theme. This might also be useful as a learning resource for users, since it's one of the most common ways to document a DS. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially, yeah, a Storybook instance for the brand-themed components would certainly be interesting! I don't know whether we have that infrastructure at the moment, but I can look into it later. As for the error and warning chips, I didn't mess with them right because they're not used at the moment (though there are opportunities to make use of them where we're customing colors by hand instead of using the |
Aside from what the title says, I also added a new page under the Experiments directory that we can fill up more over time to visualize the brand-themed components. It'll likely be easier to maintain them and make changes without getting to pages where they're available. We should've done this a long time ago 😅