Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Load commonjs files in next.config.mjs with require #41108

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 15, 2024

Noticed netlify build errors started happening the day I moved to next.config.mjs.
This PR aligns the method of loading commonjs modules using createRequire with the way Toolpad does it instead of relying on esm/cjs interop.

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Feb 15, 2024
@mui-bot
Copy link

mui-bot commented Feb 15, 2024

Netlify deploy preview

https://deploy-preview-41108--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2ccdfcb

@Janpot Janpot marked this pull request as ready for review February 15, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants