-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Add Marblism diamond sponsor #41097
[website] Add Marblism diamond sponsor #41097
Conversation
Netlify deploy previewBundle size report |
@rluzists1 Please don't use Instead, let's rely on the people responsible or accountable of https://www.notion.so/mui-org/Keep-sponsors-up-to-date-7ebff6991f2946ca853b0e1d3df3a826. |
Quick aside about this: I've added some brief review "etiquette" instructions (that can be enhanced/beefed up) on the Notion GitHub PRs page. I think we can help folks who aren't that familiar with GitHub by writing down more of these "how-to-use" guides about the tools we use! @rluzists1 I wouldn't be surprised if you have just learned about this little instruction now through trial and error, but maybe for future non-devs interacting with code, this can be handy! :) |
Thanks @danilo-leal :) I'd used the |
I pushed a fix for a two-year-old bug: #33528 (comment), and increased the pixel ratio to support mobile (usually x3) for the exiting sponsors. I didn't touch the new one (maybe I should have done this in a separate PR). The image handling of Marblism needs to be fixed though:
|
Applied the same changes to the marblism image on backers and READ.me |
39956a2
to
9beaee5
Compare
9ec4524
to
233000e
Compare
Good on my end. I polished the existing sponsors as much as I could |
…aterial-ui into marblism-diamond-sponsorship
@rluzists1 It won't work right now since the image you added only lives in your branch. Once your changes are merged to master and the docs site gets the updated code, it'll have the new image and your changes in README will also reflect the image. |
Thank you @brijeshb42 that's really helpful, I'll stop stressing about it then! In that case, all changes on my end are complete/look good; will wait for your review @danilo-leal before merging :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One question, though — we're maintaining the "Become a Diamond Sponsor" button on the documentation's TOC. Have we now expanded our diamond sponsor slots for more than three? That'd explain the button (given that, in the past, whenever we hit three, we used to remove it!).
Thanks for reviewing @danilo-leal and yes, we have in theory! I've removed other language that referenced it on the site (1/3 slots), although I haven't made changes to the parts of the code that reference it ( All good for me to click squash and merge then? |
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
https://mui.zendesk.com/agent/tickets/17044
4 locations to check: