[docs-infra] Support interfaces for X docs #41069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41069--material-ui.netlify.app/ Bundle size report |
alexfauquette
added
component: data grid
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
5 tasks
alexfauquette
commented
Feb 21, 2024
| @@ -155,7 +155,7 @@ type ExpandableApiItemProps = { | |||
| isExtendable?: boolean; | |||
| note?: string; | |||
| sx?: SxProps; | |||
| title: string; | |||
| title: string | React.ReactNode; | |||
There was a problem hiding this comment.
Allows to add a link to the pricing page when it's a pro or premium feature
| @@ -122,6 +122,9 @@ interface PropertiesTableProps { | |||
|
|
|||
| export default function PropertiesTable(props: PropertiesTableProps) { | |||
| const { properties } = props; | |||
|
|
|||
| const hasDefaultColumn = properties.some((item) => item.propDefault !== undefined); | |||
There was a problem hiding this comment.
Some interfaces don't have default values for all their attributes. In such case we simply don't show the column
bharatkashyap
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some customization of the props element to support the interface display in mui/mui-x#12016
The result can be seen here: https://deploy-preview-12016--material-ui-x.netlify.app/x/api/data-grid/grid-api/