Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[button][material-ui] Fix 'File upload' demo a11y #40943

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 5, 2024

This is a follow-up on #38823. The demo in https://mui.com/material-ui/react-button/#file-upload has two bugs that https://mui.com/joy-ui/react-button/#file-upload doesn't, so copied the solution Jun used. The bugs:

  • Double tab
  • Axe complaining about nested

Screenshot 2024-02-05 at 03 11 06

I noticed this in #40446

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work accessibility a11y component: button This is the name of the generic UI component, not the React module! component: upload This is the name of the generic UI component, not the React module! labels Feb 5, 2024
@mui-bot
Copy link

mui-bot commented Feb 5, 2024

Netlify deploy preview

https://deploy-preview-40943--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5061b97

@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Feb 5, 2024
@skmanoj322
Copy link
Contributor

@oliviertassinari can you give little more context of the bug. I am not able to understand problem statement

@oliviertassinari oliviertassinari merged commit e3b6520 into mui:master Feb 11, 2024
24 checks passed
@oliviertassinari oliviertassinari deleted the fix-file-upload-aria branch February 11, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! component: upload This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants