[docs-infra] Fix arbitrary gap between paragraphs in callouts #40911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
fix-arbitracy-callout-gap
branch
from
b9c8c7b
to
f9bed90
Compare
Netlify deploy previewhttps://deploy-preview-40911--material-ui.netlify.app/ Bundle size report |
danilo-leal
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
Looks good! I just don't understand why this is considered a regression. What was broken with the previous code? Maybe I'm not understanding, or it's worth clarifying in the PR description — not obvious from the screenshot diff. It looks more like an improvement than a bug fix to me.
@danilo-leal The #38525 PR introduced a custom gap between paragraphs: https://github.com/mui/material-ui/pull/38525/files#diff-77f04bc58bbbb50bc7d3dea9ec533b08d76f110c581114cda8105da367d236a5R283 The CSS no longer relies on the default margin-bottom value. I think it's a regression because:
This PR reverts to how it was before. |
oliviertassinari
force-pushed
the
fix-arbitracy-callout-gap
branch
from
b649901
to
b4afd2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression introduced in #38525. I noticed the problem in #40909.
Before https://deploy-preview-40909--material-ui.netlify.app/material-ui/guides/nextjs/#installing-the-dependencies
After https://deploy-preview-40911--material-ui.netlify.app/experiments/docs/callouts/#multilines