Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codemod][Accordion] Update props actual.js test case #40879

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[codemod][Accordion] Update props actual.js test case #40879

merged 1 commit into from
Feb 1, 2024

Conversation

DiegoAndai
Copy link
Member

actual.js was the same as expected.js

@DiegoAndai DiegoAndai added component: accordion This is the name of the generic UI component, not the React module! package: codemod Specific to @mui/codemod labels Jan 31, 2024
@DiegoAndai DiegoAndai self-assigned this Jan 31, 2024
@mui-bot
Copy link

mui-bot commented Jan 31, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-40879--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0252e69

oliviertassinari
oliviertassinari reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I can make the test fail locally.

siriwatknp
siriwatknp approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have forgotten to revert the change before committing 😅

@DiegoAndai DiegoAndai merged commit b98290f into mui:master Feb 1, 2024
21 checks passed
@DiegoAndai DiegoAndai deleted the codemod/accordion-props-actual-case branch February 1, 2024 13:10
mostafa-rio pushed a commit to mostafa-rio/material-ui that referenced this pull request Feb 3, 2024
@DiegoAndai @mostafa-rio
[codemod][Accordion] Update props actual.js test case (mui#40879)
0c612f7
This was referenced Feb 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees

@DiegoAndai DiegoAndai

Labels
component: accordion This is the name of the generic UI component, not the React module! package: codemod Specific to @mui/codemod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DiegoAndai @mui-bot @oliviertassinari @siriwatknp