Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove unneeded @slack/web-api package #40840

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jan 29, 2024

I don't see this package being used anywhere. Not sure why it was added in #38859.

Closes #40818

@ZeeshanTamboli ZeeshanTamboli added dependencies Update of dependencies core Infrastructure work going on behind the scenes labels Jan 29, 2024
@mui-bot
Copy link

mui-bot commented Jan 29, 2024

Netlify deploy preview

https://deploy-preview-40840--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0475bf6

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review January 29, 2024 09:08
@ZeeshanTamboli ZeeshanTamboli requested a review from a team January 29, 2024 09:10
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this package being used anywhere. Not sure why it was added in #38859.

At the time it was used in

const { WebClient } = require('@slack/web-api');
and removed in #39075

@ZeeshanTamboli ZeeshanTamboli merged commit 3824706 into mui:master Jan 29, 2024
21 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the remove-unneeded-@slack-web-api-package branch January 29, 2024 12:47
mostafa-rio pushed a commit to mostafa-rio/material-ui that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants