Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Slider] Deprecate components and componentProps props for v6 #40777

Merged

Conversation

lhilgert9
Copy link
Contributor

@lhilgert9 lhilgert9 commented Jan 24, 2024

Part of: #40417

Deprecate components and componentsProps props in favor of slots and slotProps respectively.

There wasn't much to do😊.

@mui-bot
Copy link

mui-bot commented Jan 24, 2024

@danilo-leal danilo-leal added component: slider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jan 24, 2024
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lhilgert9, looks good!

Just one comment.

packages/mui-material/src/Slider/Slider.d.ts Outdated Show resolved Hide resolved
@lhilgert9
Copy link
Contributor Author

Hey @lhilgert9, looks good!

Just one comment.

Done👍🏽

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhilgert9! 🎉

@DiegoAndai DiegoAndai merged commit c0eb421 into mui:master Feb 22, 2024
22 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@skmanoj322
Copy link
Contributor

hey @lhilgert9 right now i am trying to implement the same for badge. In codemod i created actual.js but i am not able to run
actual.js. I read CONTRIBUTING.md in codemod it says to us these command

node packages/mui-codemod/codemod deprecations/accordion-props packages/mui-codemod/src/deprecations/accordion-props/test-cases/theme.actual.js

so i used the command
node packages/mui-codemod/src/deprecations/badge-props/test-cases/actual.js
and it threw me error stating canot use import statement outside a module.

can you tell me the right command to test actual.js

@lhilgert9
Copy link
Contributor Author

Hey @skmanoj322, yes, i had my difficulties with it at the beginning too. But it should work for you with the following command: node packages/mui-codemod/codemod deprecations/badge-props packages/mui-codemod/src/deprecations/badge-props/test-cases/actual.js 🚀
If I can help you in any other way, you are welcome to write again😊

@lhilgert9 lhilgert9 deleted the mui-material/slider-v6-component-deprecation branch April 2, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants