[website] Fine-tune colors and styles on the branding theme #40751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
design
Netlify deploy previewhttps://deploy-preview-40751--material-ui.netlify.app/ Bundle size report |
1 task
| @@ -476,18 +475,18 @@ export function getThemedComponents(): ThemeOptions { | |||
| styleOverrides: { | |||
| root: ({ theme, ownerState }) => ({ | |||
| transition: 'all 120ms ease-in', | |||
| '&:active': { transform: 'scale(.96)' }, | |||
There was a problem hiding this comment.
It feels like we are missing visual feedback for the Button's active state. It doesn't have to be a scale transform, but it feels like there should be something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
transform: scalefrom both the Button and Button Base to avoid any text rasterizing upon scalinghttps://deploy-preview-40751--material-ui.netlify.app/