-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Reserve space for scrollbar #40749
[docs-infra] Reserve space for scrollbar #40749
Conversation
Netlify deploy previewhttps://deploy-preview-40749--material-ui.netlify.app/ Bundle size report |
What resolution are you using? I couldn't reproduce the layout shift here 🤔 Screen.Recording.2024-01-23.at.12.59.44.mov |
@zanivan You need a large enough screen to move from one page without a scrollbar to another with a scrollbar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need a large enough screen to move from one page without a scrollbar to another with a scrollbar.
It's really weird because there is clearly a layout shift in your video, but I couldn't reproduce it here in any way 😅
Tried to do so in the largest screen I have:
Screen.Recording.2024-01-23.at.19.11.46.mov
Anyway, I don't see any problem with adding this fix 👍
@zanivan Ah yes, it's because this https://www.notion.so/mui-org/Laptop-configuration-d306ca6120004d2e9034144e71c45b34?pvs=4#2bd404c6337443a0870ba1238293a457 |
Before, layout shift on page transiton
Screen.Recording.2024-01-23.at.01.38.17.mov
After, stable layout
Screen.Recording.2024-01-23.at.01.37.56.mov
I opened mui/base-ui#79 for what a better solution for this would be (it's annoying to see the scrollbar). This PR relies on a fix I introduced while back to support #17812 (comment)