-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Fix build on Next.js Pages Router examples #40665
[examples] Fix build on Next.js Pages Router examples #40665
Conversation
Netlify deploy previewhttps://deploy-preview-40665--material-ui.netlify.app/ Bundle size report |
deee910
to
a221352
Compare
CacheProvider?: (props: { | ||
value: EmotionCache; | ||
children: React.ReactNode; | ||
}) => React.JSX.Element | null; | ||
CacheProvider?: React.ElementType<{ value: EmotionCache }>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange type
emotionStyleTags: React.JSX.Element[]; | ||
emotionStyleTags: React.ReactElement[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://stackoverflow.com/questions/58123398/when-to-use-jsx-element-vs-reactnode-vs-reactelement for why this type didn't make much sense.
I noticed that the reproduction of #37500 still leads to an error (but a different kind):
This is a regression from #40199. It's a quick fix, so I thought I might as well go for it.