Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs][Slider] Added custom mark labels demo #40647

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

DonikaV
Copy link
Contributor

@DonikaV DonikaV commented Jan 17, 2024

Added example of how to add custom labels to the slider because of this issue
#40544

Added example how to add custom labels to the slider because of this issue
 mui#40544
@mui-bot
Copy link

mui-bot commented Jan 17, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b86d736

@zannager zannager added component: slider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jan 17, 2024
@zanivan zanivan changed the title Added Custom Labels to Slider Docs page [material-ui][docs][Slider] Added custom mark labels demo Jan 17, 2024
@zanivan zanivan added the docs Improvements or additions to the documentation label Jan 17, 2024
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some small tweaks to the design and copy, but it looks great! Design-wise, it's a green light for me :)

Thanks for this, @DonikaV!

@DonikaV
Copy link
Contributor Author

DonikaV commented Jan 17, 2024

@zanivan you welcome, was a pleasure to do something useful :)

@DonikaV
Copy link
Contributor Author

DonikaV commented Jan 17, 2024

@zanivan sorry, i dont have a Merge button, you will merge it later, right?
Thanks.

@zanivan zanivan merged commit 8cdb16a into mui:master Jan 17, 2024
20 checks passed
@DonikaV DonikaV deleted the add-custom-marks branch January 18, 2024 10:08
@DiegoAndai DiegoAndai linked an issue Jan 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Slider] Labels of the marks goes beyond the block
4 participants