[base-ui][TextareaAutosize] Add border-box to demo #40646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40646--material-ui.netlify.app/ Bundle size report |
zannager
added
component: TextareaAutosize
|
I don't quite understand why |
|
It times out sometimes. It's not related to your change. I restarted the job. |
Oh this is indeed the case, I failed ten times in local. Anyway thanks |
zanivan
approved these changes
Jan 19, 2024
Thanks for reviewing my first pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug mui/base-ui#68 seems to have relationship with #40634 due to customer root has no
border-boxattribute.