[code-infra] Improve proptypes-generation #40617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40617--material-ui.netlify.app/ Bundle size report |
|
I'm not aware of such limitations. But I haven't had much to do with the typescript-to-proptypes package so far. |
alexfauquette
commented
Jan 22, 2024
| @@ -125,6 +125,7 @@ function checkType({ | |||
| if (project.checker.isArrayType(type)) { | |||
| // @ts-ignore | |||
| const arrayType: ts.Type = project.checker.getElementTypeOfArrayType(type); | |||
|
|
|||
alexfauquette
commented
Jan 22, 2024
| @@ -94,7 +96,7 @@ export function createInterfaceType(init: { | |||
| } | |||
|
|
|||
| export function createLiteralType(init: { | |||
| value: unknown; | |||
| value: string | number | ts.PseudoBigInt; | |||
There was a problem hiding this comment.
This Type come from observing all the createLiteralType() call
two of them only take string, the last one as this typing for it's input value
alexfauquette
commented
Jan 22, 2024
| } | ||
|
|
||
| return type.type; | ||
| return getTypeHash(type); |
There was a problem hiding this comment.
Here is the root cause of the issue. If you do the union of two interfaces, they were erased because their type.type is "InterfaceNode" so only one of the two survive to the _.uniqBy
I created a getTypeHash that generate a hash in a recursive way to support interface, union and array
michaldudak
approved these changes
Jan 22, 2024
| @@ -149,6 +150,13 @@ export function uniqueUnionTypes(node: UnionType): UnionType { | |||
| return `${type.type}.${type.instance}`; | |||
| } | |||
|
|
|||
| if (type.type === 'InterfaceNode') { | |||
| // Allows union of mulitple interface nodes | |||
There was a problem hiding this comment.
Suggested change
| // Allows union of mulitple interface nodes | |
| // Allows union of multiple interface nodes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple reproduction of this issue mui/mui-x#11679
I set two way to define
ChartSeries<T>but in bot case I only get one type (not the same depending on the union chosen)However TypeScript seems to correctly understand the series type and its data type
@mui/code-infra Is it a known limitation (do you know where it comes from)? If not, I can investigate a bit further