Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add notification to publish the survey #40552

Merged

Conversation

joserodolfofreitas
Copy link
Member

@joserodolfofreitas joserodolfofreitas commented Jan 12, 2024

A continuation of #40553.

image

Caption: Notifications container with the new notification highlighted with a red rectangle

@joserodolfofreitas joserodolfofreitas added the docs Improvements or additions to the documentation label Jan 12, 2024
@mui-bot
Copy link

mui-bot commented Jan 12, 2024

Netlify deploy preview

https://deploy-preview-40552--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e3eba4d

Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
docs/notifications.json Outdated Show resolved Hide resolved
docs/notifications.json Outdated Show resolved Hide resolved
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
docs/notifications.json Outdated Show resolved Hide resolved
docs/notifications.json Outdated Show resolved Hide resolved
@joserodolfofreitas
Copy link
Member Author

@oliviertassinari @danilo-leal
I reviewed it based on the banner and feedbacks.
image

Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Left a tiny rephrasing suggestion; curious to hear what @samuelsycamore thinks about it, too!

docs/notifications.json Outdated Show resolved Hide resolved
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
@joserodolfofreitas joserodolfofreitas merged commit 9ef0fd7 into mui:master Jan 18, 2024
19 checks passed
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 23, 2024

A side note:

As I browsed the website for the last few days, I didn't realize we had the survey notification, until I looked closer at it (at first glance it felt that we didn't). I think it's because it's not clear to me that this is a survey, I stopped reading at the title:

Should do something about it? Probably not, but felt it was worth mentioning this effect, I caught myself not reading the description when the title didn't interest me. So if "survey" is more important than "influence roadmap" in the information hierarchy, we might want to reverse the order between title and description next year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants