[docs-infra] Remove old tocs banners #40537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
core
Netlify deploy previewhttps://deploy-preview-40537--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
docs-infra-remove-dead-code
branch
from
28e476a
to
92da99b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dead code, as far as I know, we won't use this again.
We already have an app banner notification for this, this is legacy:
Edit, I reverted this in the end, it's not that a bad idea after all, Base UI users sounds like good matches.
I think we learned that people who use Material UI are not the people we should hire to work on it. It much better to hire the people who think Material UI is crap and who had to rebuild it themselves because of it (e.g. my own story, and what we are doing again today, Material UI is stuck 1,2 years in the past).For Base UI and MUI System, maybe the rationale would be different. People who use Base UI could be a great fit for Material UI. So why not keep this, but then the design is outdated, so we would need to redo it anyway, and better tailor the audience. Overall, we already have so many candidate applications, that I don't know if it's so relevant: