[website] Add content about the Sync plugin in the Material UI page #40515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
the
website
Netlify deploy previewhttps://deploy-preview-40515--material-ui.netlify.app/ Bundle size report |
danilo-leal
changed the title
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
danilo-leal
changed the title
danilo-leal
added
the
needs cherry-pick
zanivan
reviewed
Apr 30, 2024
There was a problem hiding this comment.
It looks good! Just pushed a small fix for layout shift, and have a couple of remarks:
- Here, I don't think we should have colorful icons, although I like them, it's not like this anywhere—so it's a bit odd to me.
- The card layout is broken, cutting off the buttons
On a different note, I think it's worth changing the Design kits mentions to something broader, like “Design resources” or jut “Design”
@zanivan that makes sense, but there are some other related tasks (like fine-tuning the actual Design Kit description on the Store) that I'd find good to do before committing to this change. This design kit is very Material UI-centric, naturally, and we should go toward this clarity! |
zanivan
reviewed
Apr 30, 2024
zanivan
reviewed
Apr 30, 2024
zanivan
approved these changes
Apr 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
…40515) Co-authored-by: David Cnoops <davidcnoops@outlook.com> Co-authored-by: zanivan <victorzanivan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds content about the Material UI Sync plugin to the Material UI and Design Kits pages.