-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system] Polish @mui/material-nextjs #40473
[system] Polish @mui/material-nextjs #40473
Conversation
f7c9d9a
to
bf59c18
Compare
Netlify deploy previewhttps://deploy-preview-40473--material-ui.netlify.app/ Bundle size report |
@@ -1,2 +1 @@ | |||
'use client'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should only "use client" where it's required. There is no client-side React API used in this module.
import { CacheProvider as DefaultCacheProvider } from '@emotion/react'; | ||
import type { EmotionCache, Options as OptionsOfCreateCache } from '@emotion/cache'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate import.
Yes, that is the goal. #40265 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Light polish on the package.
Off-topic. It feels like we should also have a
@mui/system-nextjs
package. Today, all the logic is about@mui/system
. The dependency on @mui/material will only start to make sense if we have components integration. But what is there to integrate with? Link, that's it?Sure, we could also add a linear progress bar between pages, but it doesn't feel like something that should be hidden behind an npm package.