Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable menu items #402

Merged
merged 4 commits into from
Mar 13, 2015
Merged

Disable menu items #402

merged 4 commits into from
Mar 13, 2015

Conversation

jkruder
Copy link
Contributor

@jkruder jkruder commented Mar 8, 2015

Menu items can now be disabled. LINK menu items will lose the context menu entries for 'Open In New Tab/Window' if the are disabled. A menu item with a toggle will disable the toggle and the menu item (no hover change) as well as display the default cursor.

Moved the menu components into js/menu/*; the changes to LINK involved some logic that menu should not care about. SUBHEADER was extracted so that MenuItems are consistent. If this is an issue let me know and I'll flatten.

@mmrtnz
Copy link
Contributor

mmrtnz commented Mar 11, 2015

Can you please resubmit this PR without build files app.js and build.js? Thank you!

@jkruder
Copy link
Contributor Author

jkruder commented Mar 11, 2015

Can do. I'll resubmit tonight/tomorrow morning.

@jkruder
Copy link
Contributor Author

jkruder commented Mar 12, 2015

Removed build files.

},

_handleOnClick: function(e) {
if (this.props.onClick) this.props.onClick(e, this.props.index);
console.log('inside menu-item click: ' + this.props.disabled);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this console log?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

mmrtnz added a commit that referenced this pull request Mar 13, 2015
@mmrtnz mmrtnz merged commit aacfbc1 into mui:master Mar 13, 2015
@mmrtnz mmrtnz mentioned this pull request Mar 17, 2015
@jkruder jkruder deleted the disable-menu-items branch March 18, 2015 13:49
@zannager zannager added the component: menu This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants