Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5.14.14 #39475

Merged
merged 1 commit into from
Oct 17, 2023
Merged

v5.14.14 #39475

merged 1 commit into from
Oct 17, 2023

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 requested a review from a team October 16, 2023 18:04
@brijeshb42 brijeshb42 added the release We are shipping :D label Oct 16, 2023
@mui-bot
Copy link

mui-bot commented Oct 16, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39475--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0a4c703

@ZeeshanTamboli ZeeshanTamboli changed the title v5.14.8 v5.14.14 Oct 17, 2023
@brijeshb42 brijeshb42 force-pushed the v5.14.14 branch 3 times, most recently from 2b4812d to 177ceac Compare October 17, 2023 08:49
mnajdova
mnajdova reviewed Oct 17, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/package.json Outdated Show resolved Hide resolved
docs/package.json
"@mui/types": "^7.2.6",
"@mui/utils": "^5.14.13",
"@mui/x-charts": "^6.0.0-alpha.14",
"@mui/x-charts": "6.0.0-alpha.14",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me. I wonder why it wasn't defined like this before. cc @alexfauquette

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific reasons

mnajdova
mnajdova reviewed Oct 17, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
mnajdova
mnajdova reviewed Oct 17, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@brijeshb42 brijeshb42 force-pushed the v5.14.14 branch 3 times, most recently from d2e5358 to 50b9378 Compare October 17, 2023 10:12
@brijeshb42 brijeshb42 enabled auto-merge (squash) October 17, 2023 10:21
@brijeshb42 brijeshb42 merged commit a7b3fba into mui:master Oct 17, 2023
22 checks passed
@brijeshb42 brijeshb42 deleted the v5.14.14 branch October 17, 2023 10:39
@Rugvip
Copy link

Rugvip commented Oct 17, 2023

Hi! Looks like @mui/styled-engine didn't get released as part of this. We're seeing breakages when importing the latest version of @mui/system because MUIStyledComponent from #39395 is missing

@Rugvip
Copy link

Rugvip commented Oct 17, 2023

Just in case, 👀 ☝️ @mnajdova @brijeshb42

@brijeshb42
Copy link
Contributor Author

brijeshb42 commented Oct 17, 2023 •
edited
Loading

@Rugvip The change that you are talking about was actually released and the package name and version is @mui/styled-engine-sc@6.0.0-alpha.2. Are you using styled-engine or styled-engine-sc?
The type is in the published version (line 332)
edit: NVM, found the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@alexfauquette alexfauquette alexfauquette left review comments

Assignees
No one assigned
Labels
release We are shipping :D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brijeshb42 @mui-bot @Rugvip @mnajdova @alexfauquette