Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Remove redundant error prop from input validation demo #39280

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Oct 3, 2023

@sai6855 sai6855 added the docs Improvements or additions to the documentation label Oct 3, 2023
@sai6855 sai6855 changed the title [joy-ui][Input] Remove redundant error prop [joy-ui][Input] Remove redundant error prop from demo Oct 3, 2023
@sai6855 sai6855 added package: joy-ui Specific to @mui/joy enhancement This is not a bug, nor a new feature labels Oct 3, 2023
@mui-bot
Copy link

mui-bot commented Oct 3, 2023

Netlify deploy preview

https://deploy-preview-39280--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6bba6d9

@@ -12,11 +12,7 @@ export default function InputValidation() {
<Input placeholder="Type in here…" error defaultValue="Oh no, error found!" />
<FormControl error>
<FormLabel>Label</FormLabel>
<Input
placeholder="Type in here…"
error
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error is not required here as it will be inherited from FormControl

@ZeeshanTamboli ZeeshanTamboli changed the title [joy-ui][Input] Remove redundant error prop from demo [docs][joy-ui] Remove redundant error prop from input validation demo Oct 6, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit e619ba1 into mui:master Oct 6, 2023
21 of 22 checks passed
@sai6855 sai6855 deleted the remove-redundant-prop branch October 6, 2023 12:09
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants