-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[base-ui][Button] Maintain the disabled prop in SSR #39212
Conversation
…nextjs ssr Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Netlify deploy previewhttps://deploy-preview-39212--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
I have not tested this, but one problem I ran into when making my local patch fix is hydration mismatching (i.e. the server adding the |
nit on the title: I think the issue applies to all SSR, not just Next.js 😬 |
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Thanks for the feedback @simon-abbott, the implementation has been updated |
I thought this would still cause some hydration mismatch errors (Next.js 😪 ) but I tested it a bunch and it seems to work ok! CC @DiegoAndai for a quick review as well 🙏 |
I have the same thought: how is it not causing errors? 😅 For example, shouldn't this be an immediate hydration mismatch if passing a |
Description
Update button component to maintain button
disabled
prop across Next.js SSRcloses #38943
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.