Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.14.11 #39153

Merged
merged 4 commits into from
Sep 26, 2023
Merged

v5.14.11 #39153

merged 4 commits into from
Sep 26, 2023

Conversation

michaldudak
Copy link
Member

No description provided.

@michaldudak michaldudak added the release We are shipping :D label Sep 25, 2023
@michaldudak michaldudak requested a review from a team September 25, 2023 12:30
@mui-bot
Copy link

mui-bot commented Sep 25, 2023

Netlify deploy preview

https://deploy-preview-39153--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 61c71b5


- [TreeView] Fix JSDoc comments in TreeView and TreeItem (#38874) @jergason

### Docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of similar to what we're doing with the Core section, should we discriminate for which product these documentation-related improvements are for? Some of them are general doc changes (e.g., "Improve the default theme viewer design"), while others are Joy UI-focused (e.g., "Refine the Sign in template", "Revise the Drawer page", etc.), and so on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiegoAndai is working on a proposal for the rules that should apply on the changelog. Until we decide on it, we can keep it as is I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. Would you find it useful? TBH I don't think including doc-related PRs in the changelog brings value to developers. In my opinion, it would be sufficient to include only the changes in packages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's at least sweet to signal that there are constant and frequent documentation improvements; it's a crucial part of the developer experience. But, cool, I'm down to hold changes until the proposal is sorted. 🤙

CHANGELOG.md Outdated Show resolved Hide resolved

### `@mui/base@5.0.0-beta.17`

- [NumberInput] Support adornments (#38900) @anle9650
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see external contribution :)


- [TreeView] Fix JSDoc comments in TreeView and TreeItem (#38874) @jergason

### Docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiegoAndai is working on a proposal for the rules that should apply on the changelog. Until we decide on it, we can keep it as is I think.

packages/mui-styles/package.json Outdated Show resolved Hide resolved
packages/mui-system/package.json Outdated Show resolved Hide resolved
packages/mui-system/package.json Outdated Show resolved Hide resolved
test/package.json Outdated Show resolved Hide resolved
@sai6855
Copy link
Contributor

sai6855 commented Sep 25, 2023

This PR can be merged #38996

@DiegoAndai
Copy link
Member

DiegoAndai commented Sep 25, 2023

Let's wait for this revert PR to be merged first: #39156. Thanks 🙌🏼

We're reverting to keep working on it.

CHANGELOG.md Outdated Show resolved Hide resolved
packages/mui-material/package.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 26, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 26, 2023
@michaldudak
Copy link
Member Author

@mui/core it's now ready for re-review.

@michaldudak michaldudak merged commit 13c0894 into mui:master Sep 26, 2023
22 checks passed
@michaldudak michaldudak deleted the release/5.14.11 branch September 26, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants