-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.14.11 #39153
v5.14.11 #39153
Conversation
Netlify deploy previewhttps://deploy-preview-39153--material-ui.netlify.app/ Bundle size report |
|
||
- [TreeView] Fix JSDoc comments in TreeView and TreeItem (#38874) @jergason | ||
|
||
### Docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of similar to what we're doing with the Core section, should we discriminate for which product these documentation-related improvements are for? Some of them are general doc changes (e.g., "Improve the default theme viewer design"), while others are Joy UI-focused (e.g., "Refine the Sign in template", "Revise the Drawer page", etc.), and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DiegoAndai is working on a proposal for the rules that should apply on the changelog. Until we decide on it, we can keep it as is I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. Would you find it useful? TBH I don't think including doc-related PRs in the changelog brings value to developers. In my opinion, it would be sufficient to include only the changes in packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's at least sweet to signal that there are constant and frequent documentation improvements; it's a crucial part of the developer experience. But, cool, I'm down to hold changes until the proposal is sorted. 🤙
|
||
### `@mui/base@5.0.0-beta.17` | ||
|
||
- [NumberInput] Support adornments (#38900) @anle9650 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see external contribution :)
|
||
- [TreeView] Fix JSDoc comments in TreeView and TreeItem (#38874) @jergason | ||
|
||
### Docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DiegoAndai is working on a proposal for the rules that should apply on the changelog. Until we decide on it, we can keep it as is I think.
This PR can be merged #38996 |
Let's wait for this revert PR to be merged first: #39156. Thanks 🙌🏼 We're reverting to keep working on it. |
f59d27d
to
65a63ed
Compare
@mui/core it's now ready for re-review. |
65a63ed
to
0153945
Compare
No description provided.