-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField][material-ui] Polish types in Textfield demo #39140
Conversation
@@ -54,13 +54,8 @@ const NumericFormatCustom = React.forwardRef<NumericFormatProps, CustomProps>( | |||
}, | |||
); | |||
|
|||
interface State { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required as ts will infer type of values
as
{
textmask: string;
numberformat: string;
}
Netlify deploy previewhttps://deploy-preview-39140--material-ui.netlify.app/ Bundle size report |
Side note. It makes me think that we could replace <Box
sx={{
'& > :not(style)': {
m: 1,
},
}}
> with the |
Total 3 demos have this selector, so maybe it's better to do all of them at once in single PR |
Thanks for working on this 🎉
@sai6855 could you create an issue/PR for this, pointing out the demos 😊 |
Fixes: https://mui-org.slack.com/archives/C041SDSF32L/p1695568788634319
Preview: https://deploy-preview-39140--material-ui.netlify.app/material-ui/react-text-field/#integration-with-3rd-party-input-libraries