Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField][material-ui] Polish types in Textfield demo #39140

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Sep 24, 2023

@sai6855 sai6855 added docs Improvements or additions to the documentation component: text field This is the name of the generic UI component, not the React module! typescript enhancement This is not a bug, nor a new feature labels Sep 24, 2023
@@ -54,13 +54,8 @@ const NumericFormatCustom = React.forwardRef<NumericFormatProps, CustomProps>(
},
);

interface State {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required as ts will infer type of values as

{
  textmask: string;
  numberformat: string;
}

@mui-bot
Copy link

mui-bot commented Sep 24, 2023

Netlify deploy preview

https://deploy-preview-39140--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6eb4c72

@oliviertassinari
Copy link
Member

Side note. It makes me think that we could replace

    <Box
      sx={{
        '& > :not(style)': {
          m: 1,
        },
      }}
    >

with the <Stack> now that the component exists.

@sai6855
Copy link
Contributor Author

sai6855 commented Sep 25, 2023

sx={{
        '& > :not(style)': {
          m: 1,
        },
      }}

Total 3 demos have this selector, so maybe it's better to do all of them at once in single PR

@DiegoAndai
Copy link
Member

Thanks for working on this 🎉

Total 3 demos have this selector, so maybe it's better to do all of them at once in single PR

@sai6855 could you create an issue/PR for this, pointing out the demos 😊

@DiegoAndai DiegoAndai merged commit 5cc443f into mui:master Sep 26, 2023
22 of 23 checks passed
@sai6855 sai6855 deleted the polish-demo branch September 27, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants