Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][useTabs] Align external props handling for useTab/useTabPanel/useTabsList #39037

Merged
merged 3 commits into from
Oct 3, 2023
Merged

[base-ui][useTabs] Align external props handling for useTab/useTabPanel/useTabsList #39037

merged 3 commits into from
Oct 3, 2023

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Sep 18, 2023 •
edited
Loading

Part of #38186

This PR aligns the typing/handling of external props for useTab, useTabsList and useTabPanel and adds some simple tests

@mj12albert mj12albert added the package: base-ui Specific to @mui/base label Sep 18, 2023
@mj12albert mj12albert mentioned this pull request Sep 18, 2023
Closed
8 tasks
@mui-bot
Copy link

mui-bot commented Sep 18, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39037--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 7c02728

@mj12albert mj12albert marked this pull request as ready for review September 18, 2023 14:20
mnajdova
mnajdova approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry for the delay :)

@mj12albert mj12albert merged commit 3de335f into mui:master Oct 3, 2023
22 checks passed
@mj12albert mj12albert deleted the base/use-tabs-external-props branch October 3, 2023 12:57
@mj12albert mj12albert mentioned this pull request Oct 3, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

Assignees
No one assigned
Labels
package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mj12albert @mui-bot @mnajdova