Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][useSnackbar] Align externalProps handling #38935

Merged
merged 3 commits into from
Sep 13, 2023
Merged

[base-ui][useSnackbar] Align externalProps handling #38935

merged 3 commits into from
Sep 13, 2023

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Sep 12, 2023 •
edited
Loading

Part of #38186

This PR aligns the typing and handling of external props and event handlers

@mj12albert mj12albert added component: snackbar This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Sep 12, 2023
@mui-bot
Copy link

mui-bot commented Sep 12, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38935--material-ui.netlify.app/

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 9758870

@mj12albert mj12albert force-pushed the base/use-snackbar-external-props branch from 54151d8 to 9758870 Compare September 12, 2023 11:27
@mj12albert mj12albert mentioned this pull request Sep 12, 2023
Closed
8 tasks
@mj12albert mj12albert marked this pull request as ready for review September 12, 2023 14:38
DiegoAndai
DiegoAndai approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏼

@mj12albert mj12albert merged commit 3b936eb into mui:master Sep 13, 2023
21 checks passed
@mj12albert mj12albert deleted the base/use-snackbar-external-props branch September 13, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
component: snackbar This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mj12albert @mui-bot @DiegoAndai