[Switch] Simplify source #38910
Merged
[Switch] Simplify source #38910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: switch
Netlify deploy previewhttps://deploy-preview-38910--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
michaldudak
added
package: base-ui
anon-phantom
pushed a commit
to anon-phantom/material-ui
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement https://github.com/mui/material-ui/pull/38570/files#r1299412334. The goal is to simplify the mental model, trying to have hooks feed in from all the props as often as possible.
I had a quick look at two libraries that have a similar hook + component pattern to see how they handle it, out of curiosity: