[TreeView][lab] Fix JSDoc comments in TreeView and TreeItem #38874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jamison Dance <hi@jamison.dance>
Netlify deploy previewhttps://deploy-preview-38874--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
@jergason Thanks for the fix! Could you also update it in the Tree Item file?
--- a/packages/mui-lab/src/TreeItem/TreeItem.tsx
+++ b/packages/mui-lab/src/TreeItem/TreeItem.tsx
@@ -23,7 +23,7 @@ const warn = () => {
};
/**
- * @deprecated The TreeItem component was moved from `@mui/lab` to `@mui/x-date-pickers`. More information about this mi
gration on our blog: https://mui.com/blog/lab-tree-view-to-mui-x/.
+ * @deprecated The TreeItem component was moved from `@mui/lab` to `@mui/x-tree-view`. More information about this migra
tion on our blog: https://mui.com/blog/lab-tree-view-to-mui-x/.
* @ignore - do not document.
*/
const TreeItem = React.forwardRef(function DeprecatedTreeItem(Additionally, please merge with the latest master branch.
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
bug 🐛
I fixed this. I was not able to push on your branch so I had added this comment, but now I could. |
ZeeshanTamboli
changed the title
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Jamison Dance <hi@jamison.dance> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the JSDoc comment to point folks to the
@mui/x-tree-viewpackage instead of@mui/x-date-pickers.