-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Remove unnecessary @types/webpack
package
#38720
[core] Remove unnecessary @types/webpack
package
#38720
Conversation
Netlify deploy previewhttps://deploy-preview-38720--material-ui.netlify.app/ Bundle size report |
@types/weback
package@types/webpack
package
I found usages of webpack types in material-ui/packages/markdown/loader.js Line 77 in e788009
and
|
@michaldudak Yes, those types are directly from the webpack package itself. You can find the types here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok, in this case, we can merge it.
Closes #38660
Looks like the webpack types are not used anywhere. It was initially added in #22720.