Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove unnecessary @types/webpack package #38720

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Aug 30, 2023

Closes #38660

Looks like the webpack types are not used anywhere. It was initially added in #22720.

@ZeeshanTamboli ZeeshanTamboli added dependencies Update of dependencies core Infrastructure work going on behind the scenes labels Aug 30, 2023
@mui-bot
Copy link

mui-bot commented Aug 30, 2023

Netlify deploy preview

https://deploy-preview-38720--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2e6101f

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review August 30, 2023 07:30
@ZeeshanTamboli ZeeshanTamboli changed the title [core] Remove unnecessary @types/weback package [core] Remove unnecessary @types/webpack package Aug 30, 2023
@michaldudak
Copy link
Member

I found usages of webpack types in

* @type {import('webpack').loader.Loader}

and

* @type {import('webpack').Configuration}

@ZeeshanTamboli
Copy link
Member Author

I found usages of webpack types in

* @type {import('webpack').loader.Loader}

and

* @type {import('webpack').Configuration}

@michaldudak Yes, those types are directly from the webpack package itself. You can find the types here.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, in this case, we can merge it.

@ZeeshanTamboli ZeeshanTamboli merged commit 7e2e737 into mui:master Aug 30, 2023
20 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the remove-unnecessary-@types-webpack-package branch August 30, 2023 13:25
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants