[docs][base] Add Tailwind CSS + plain CSS demo on the Menu page #38618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewBundle size report |
zannager
added
docs
mnajdova
requested changes
Aug 25, 2023
| @@ -19,7 +19,7 @@ export default function MenuIntroduction() { | |||
| <StyledMenuItem onClick={createHandleMenuClick('Profile')}> | |||
| Profile | |||
| </StyledMenuItem> | |||
| <StyledMenuItem onClick={createHandleMenuClick('My account')}> | |||
| <StyledMenuItem onClick={createHandleMenuClick('Language settings')}> | |||
| return ( | ||
| <div className={`${isDarkMode ? 'dark' : ''}`}> | ||
| <Dropdown> | ||
| <MenuButton className="cursor-pointer text-sm min-h-[calc(1.5em+22px)] font-sans box-border rounded-xl font-semibold px-3.5 py-2 leading-normal bg-white dark:bg-slate-900 border border-solid border-slate-300 dark:border-slate-700 text-slate-900 dark:text-slate-300 hover:bg-slate-50 hover:dark:bg-slate-800 hover:border-slate-300 dark:hover:border-slate-600 focus-visible:border-purple-500 focus-visible:hover:border-purple-500 focus-visible:dark:hover:border-purple-500 focus-visible:outline-0 focus-visible:shadow-outline-purple"> |
There was a problem hiding this comment.
We should create our own version of the MenuButton and the MenuItem componetn similar as done with the Menu. It would simplify a lot the demo code.
There was a problem hiding this comment.
Thanks @mnajdova, I just added the custom version of MenuButton and MenuItem for both demos. Please let me know if it addresses your comment :)
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
anon-phantom
pushed a commit
to anon-phantom/material-ui
that referenced
this pull request
Sep 11, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #37222