-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Adjust site to add Toolpad on the homepage #38604
Conversation
Netlify deploy previewhttps://deploy-preview-38604--material-ui.netlify.app/ Bundle size report |
Nice one! I had quickly experimented with adding Toolpad before when y'all opened the issue and anticipated Olivier's point 1 there. Looking at it again, this might be the opportunity to remove the Design kits + Templates from there (as something on the same level as Core & X) and add them as sections within the Material UI page (and later on, similar ones for Joy UI). That way, we gain way more space for the products that sit at the same level, and therefore, Toolpad! I can make this one in parallel ⎯ @oliviertassinari; we discussed doing this in the past, but I just want to reiterate and see we're still on the same page. About point 2, yeah,I think that at least a video would be great. A static image doesn't communicate much... |
It makes sense. Base UI could likely benefit from templates as well. We don't have any, but we might in the future.
Screen.Recording.2023-08-23.at.12.58.25.mov |
Bringing this PR back into the discussion:
|
I want to remove "MUI Core" at some point and replace it with everything inside this conceptual umbrella: Material UI, Base UI, Pigment CSS, and possibly Joy UI (to be defined after we scope out v7). We'll probably need to redesign this section a bit to pull that off. However, I'm visualizing a more holistic website redesign this year to go alongside the brand stuff we're carrying out with the consultancy. That's why I'm not necessarily pushing to do that immediately. In any case, for now, if we want to add Toolpad there, I'd potentially drop Templates and Design kits and replace them with a Store item, which encapsulates both of them (at least for now). That'd keep us with a four-item section, which fits well with the current design. Hope this perspective helps! |
Great! This will help. Thanks. |
@danilo-leal We're looking to get this done inside the Toolpad team, and I noted your suggestion of a common entry for the Design Kits and Templates. Does it still make sense to do this? I'm asking because we wouldn't be able to link to https://mui.com/templates/ from this section anymore (we would instead link to the Store) and would need to create a new combined design asset |
I think so, yes! Is there any concern regarding swapping out the Design Kits/Templates item for a Store item? How does this impact Toolpad specifically? |
The question in my mind is essentially, what do we put in these red boxes for the combined store item and who comes up with them: |
Ah, gotcha. No need to worry about it; I'll take on the design. I'll add commits soon to the PR if that's the case. |
Okay—just pushed the structure/design for the tabs approach! Let me know (feel free to send it over via Slack) the images we want to use in each tab panel (if possible, it'd be great to have one for light and dark mode, as opposed to just a light one), and in what part of it I should add the magnifying thingy on. Also, feel free to change the code snippets and tab names! 👍 Getting finally closer to wrapping this PR up! |
Thank you @danilo-leal. Quickly trying it out. My first impressions on the UX are:
|
e84e880
to
3cf8e55
Compare
Quick update here for context: chatted with Bharat in private, and given I pushed a lot of general website changes on this PR—even though most of them were the product of adding Toolpad to the homepage—we still felt like it was better to separate things into two PRs, for better traceability in the future. So, in summary:
|
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Preview: https://deploy-preview-38604--material-ui.netlify.app/
This PR was originally created to add Toolpad to the website's homepage, but we've ended up using it as an opportunity to do some other stray fixes that would benefit the main goal. However, to separate things and have better traceability, we chose to remove the Toolpad content from this one and put it on a dedicated follow-up PR while maintaining this PR as just a "preparatory" sort of phase.