-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dropdown] Fix imports of types #38296
[Dropdown] Fix imports of types #38296
Conversation
Netlify deploy previewhttps://deploy-preview-38296--material-ui.netlify.app/ Bundle size report |
Can you describe the issue and provide a reproduction? I'd argue it "breaks typescript build for everyone" as our CI passes without errors. |
Hello @michaldudak This is the issue that our entire team was facing after our CI/CD picked up the latest release. Let me know if you need any more information. Thanks! |
The PR looks correct https://www.typescriptlang.org/docs/handbook/modules.html#importing-types, as far as I understand it. We broke compatibility for TypeScript version <4.5, which goes against
https://mui.com/material-ui/getting-started/supported-platforms/#typescript
@yash-thakur I'm curious, which MUI open-source project are you using? What's your TypeScript version? |
@oliviertassinari |
Strange then, it should work for you https://devblogs.microsoft.com/typescript/announcing-typescript-4-5/#type-on-import-names (the release notes of TS are so great, they cover the problem well each time 😊). |
Then maybe because my system has overall tsc version as 4.4.4 which is <4.5 that causes the issue. |
@yash-thakur Thanks for the details. Could you please update the PR to change only the problematic lines and leave the rest as before? |
Thanks for working on this! |
There was an issue in the latest version related to types which breaks typescript build for everyone.