Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to prevent menu close on itemclick #376

Merged
merged 2 commits into from
Mar 3, 2015
Merged

Conversation

WRidder
Copy link
Contributor

@WRidder WRidder commented Feb 28, 2015

I would like to have the option to prevent menu closing when clicking on items, for example in case of using toggles it's annoying the menu closes on every click. Current PR only focuses on the drop-down-icon component, however, if useful, may be applied to other menu components as well.

I would like to have the option to prevent menu closing when clicking on items, for example in case of using toggles it's annoying the menu closes on every click. Current PR only focuses on the `drop-down-icon` component, however, if useful, may be applied to other menu components as well.
@hai-cea
Copy link
Member

hai-cea commented Mar 2, 2015

Yes, thanks @WRidder !

@WRidder
Copy link
Contributor Author

WRidder commented Mar 3, 2015

Updated. Added getInitialProps() for the default closeOnMenuItemClick value.

hai-cea added a commit that referenced this pull request Mar 3, 2015
Option to prevent menu close on itemclick
@hai-cea hai-cea merged commit ffb4baf into mui:master Mar 3, 2015
@hai-cea
Copy link
Member

hai-cea commented Mar 3, 2015

Thanks @WRidder 👍

@zannager zannager added the component: menu This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants