Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Builder] Move to packages directory #3680

Merged
merged 1 commit into from
Mar 13, 2016
Merged

[Icon Builder] Move to packages directory #3680

merged 1 commit into from
Mar 13, 2016

Conversation

mbrookes
Copy link
Member

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Following the recent discussion, this PR moves icon-builder to the proposed packages directory.

@newoga
Copy link
Contributor

newoga commented Mar 13, 2016

Maybe we should rename the folder to material-ui-icons or rename the package.json package name to material-ui-icon-builder. And maybe add private: true to the package.json for now too.

@mbrookes
Copy link
Member Author

@newoga - done.

mbrookes added a commit that referenced this pull request Mar 13, 2016
[Icon Builder] Move to packages directory
@mbrookes mbrookes merged commit 612afa8 into mui:master Mar 13, 2016
@mbrookes mbrookes deleted the icon-builder-move-to-packages branch March 19, 2016 01:24
@zannager zannager added the package: icons Specific to @mui/icons label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: icons Specific to @mui/icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants