[CardHeader] handle wide titles: allow them to wrap #3503
Conversation
|
(I'm currently adding |
|
Oh my, before is really ugly! Any chance we can flexbox this? |
|
I'm a flexbox newbie, any hint? |
|
Well there are many cases where we should use flexbox. I think it's best if we merge this now and take care of migrating to flexbox later. 👍 |
|
All green here 👍 @callemall/material-ui Feel free to merge guys. |
| @@ -7,15 +7,18 @@ function getStyles(props, state) { | |||
|
|
|||
| return { | |||
| root: { | |||
| height: 72, | |||
| height: 'auto', | |||
There was a problem hiding this comment.
That's the default value. Do we need this?
There was a problem hiding this comment.
well for me the height depends on the content, I don't see why it was fixed?
There was a problem hiding this comment.
I agree, hard-coding the height to 72 sounds like a bad idea. My point is that 'auto' is the default style value for the height property, we can remove this line.
There was a problem hiding this comment.
oh yes right :)
mbrookes
changed the title
…tles [CardHeader] handle wide titles: allow them to wrap
|
@antoinerousseau Thanks |
…-titles [CardHeader] handle wide titles: allow them to wrap
zannager
added
the
component: card
Before:
After: